-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for Issue #91 #92
base: master
Are you sure you want to change the base?
Conversation
👇 Click on the image for a new way to code review
Legend |
Are you checking this @shauryauppal? Would you like me to change anything? |
@shauryauppal , Is this PR merged? |
I have approved it. Looks good to me but before merging. I wanted to do a
code run
…On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar ***@***.***> wrote:
@shauryauppal <https://github.com/shauryauppal> , Is this PR merged?
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Also you missed to change requirements.txt for new library install
On Sun, 30 Oct 2022 at 7:41 PM, Shaurya Uppal ***@***.***>
wrote:
… I have approved it. Looks good to me but before merging. I wanted to do a
code run
On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar ***@***.***>
wrote:
> @shauryauppal <https://github.com/shauryauppal> , Is this PR merged?
>
> —
> Reply to this email directly, view it on GitHub
> <#92 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sure, thanks. |
So sry, should I raise a new PR or you'll do it on your own? |
Please make the change with correct library version
On Sun, 30 Oct 2022 at 7:46 PM, Nitin Kumar ***@***.***>
wrote:
… Also you missed to change requirements.txt for new library install On Sun,
30 Oct 2022 at 7:41 PM, Shaurya Uppal *@*.
*> wrote: … <#m_-7749873979663347661_> I have approved it. Looks good to
me but before merging. I wanted to do a code run On Sun, 30 Oct 2022 at
7:12 PM, Nitin Kumar @.*> wrote: > @shauryauppal
<https://github.com/shauryauppal> https://github.com/shauryauppal , Is
this PR merged? > > — > Reply to this email directly, view it on GitHub > <#92
(comment)
<#92 (comment)>>,
> or unsubscribe >
https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM
> . > You are receiving this because you were mentioned.Message ID: > *@*.***>
>
So sry, should I raise a new PR or you'll do it on your own?
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3FQZO5D5LJHADRQMS5WMLWFZ7M7ANCNFSM6AAAAAAQ2MCPMM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
As discussed, I've tried implementing the ' No need to download web driver ' feature enhanced with the updated README file. Refer to Issue #91 for the same. Thanks. Kindly put the tag of hacktoberfest2022 in this.