Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for Issue #91 #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nitinkumar30
Copy link

As discussed, I've tried implementing the ' No need to download web driver ' feature enhanced with the updated README file. Refer to Issue #91 for the same. Thanks. Kindly put the tag of hacktoberfest2022 in this.

@ghost
Copy link

ghost commented Oct 1, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@nitinkumar30
Copy link
Author

Are you checking this @shauryauppal? Would you like me to change anything?

@nitinkumar30
Copy link
Author

@shauryauppal , Is this PR merged?

@shauryauppal
Copy link
Owner

shauryauppal commented Oct 30, 2022 via email

@shauryauppal
Copy link
Owner

shauryauppal commented Oct 30, 2022 via email

@nitinkumar30
Copy link
Author

I have approved it. Looks good to me but before merging. I wanted to do a code run

On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.> wrote: @shauryauppal https://github.com/shauryauppal , Is this PR merged? — Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.>

Sure, thanks.

@nitinkumar30
Copy link
Author

Also you missed to change requirements.txt for new library install On Sun, 30 Oct 2022 at 7:41 PM, Shaurya Uppal @.> wrote:

I have approved it. Looks good to me but before merging. I wanted to do a code run On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.
> wrote: > @shauryauppal https://github.com/shauryauppal , Is this PR merged? > > — > Reply to this email directly, view it on GitHub > <#92 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM > . > You are receiving this because you were mentioned.Message ID: > @.***> >

So sry, should I raise a new PR or you'll do it on your own?

@shauryauppal
Copy link
Owner

shauryauppal commented Oct 30, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants