Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify verify_mkvmerge #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify verify_mkvmerge #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions pymkv/Verifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import os
from os.path import expanduser, isfile
from re import match
from shutil import which
import subprocess as sp


Expand All @@ -16,13 +17,7 @@ def verify_mkvmerge(mkvmerge_path='mkvmerge'):
mkvmerge_path (str):
Alternate path to mkvmerge if it is not already in the $PATH variable.
"""
try:
output = sp.check_output([mkvmerge_path, '-V']).decode()
except (sp.CalledProcessError, FileNotFoundError):
return False
if match('mkvmerge.*', output):
return True
return False
return which(mkvmerge_path) is not None


def verify_matroska(file_path, mkvmerge_path='mkvmerge'):
Expand Down