Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fileRealPath files lookup in data.files #1

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yukihiko-shinoda
Copy link

Hi, thanks for maintaining and deploying plugin on behalf.

Would you review and merge also this pull request?
Following issue is still reproduced.
Bug in lint method of the PhpcsLinter class · Issue #128 · ikappas/vscode-phpcs
can not show error message · Issue #132 · ikappas/vscode-phpcs

I'm sorry, I don't have enough experience about developing VS Code plugin
so I can't have complete confidence about contents of updates in this pull request well.


Original message:

  • Changed 2016 to 2017 in tsconfig.json, need access to Object.entries
  • Fixed issue in phpcs-server/src/linter.ts

Signed-off-by: Blake Cerecero [email protected]

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- Changed 2016 to 2017 in tsconfig.json, need access to Object.entries
- Fixed issue in phpcs-server/src/linter.ts

Signed-off-by: Blake Cerecero <[email protected]>
@wakkoism
Copy link

Any chance we can get this merged in? I've tested the patch and can confirm that this works with basepath.

@RoestVrijStaal
Copy link

Ping @shevaua

@nsrosenqvist
Copy link

Is @shevaua still maintaining the extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants