Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test Bump cpp to 3.4.1 #36

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/mac/build-cpp-deps-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,11 @@ if [ ! -f protobuf-${PROTOBUF_VERSION}.done ]; then
curl -O -L https://github.com/google/protobuf/releases/download/v${PROTOBUF_VERSION}/protobuf-cpp-${PROTOBUF_VERSION}.tar.gz
tar xfz protobuf-cpp-${PROTOBUF_VERSION}.tar.gz
pushd protobuf-${PROTOBUF_VERSION}
CXXFLAGS="-fPIC -arch arm64 -arch x86_64 -mmacosx-version-min=${MACOSX_DEPLOYMENT_TARGET}" \
./configure --prefix=$PREFIX
make -j16 V=1
make install
pushd cmake/
cmake -B build -DCMAKE_CXX_FLAGS="-fPIC -arch arm64 -arch x86_64 -mmacosx-version-min=${MACOSX_DEPLOYMENT_TARGET}" \
-DCMAKE_INSTALL_PREFIX=$PREFIX
cmake --build build -j16 --target install
popd
popd

pushd install/lib
Expand Down
4 changes: 2 additions & 2 deletions pulsar-client-cpp.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
CPP_CLIENT_BASE_URL=https://archive.apache.org/dist/pulsar/pulsar-client-cpp-3.2.0
CPP_CLIENT_VERSION=3.2.0
CPP_CLIENT_BASE_URL=https://archive.apache.org/dist/pulsar/pulsar-client-cpp-3.4.1
CPP_CLIENT_VERSION=3.4.1
2 changes: 1 addition & 1 deletion tests/consumer.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ const Pulsar = require('../index');

await expect(consumer.close()).resolves.toEqual(null);

await expect(consumer.close()).rejects.toThrow('Failed to close consumer: AlreadyClosed');
await expect(consumer.close()).resolves.toEqual(null);
});
});

Expand Down
Loading