feat: student schema changes #41
Conversation
shikharvashistha
force-pushed
the
feat/student-schema
branch
from
298f980 to
10db08c
Compare
|
Hi, the student schema is currently implemented as DTOs here - https://github.com/shiksha-platform/backend-v2/tree/main/src/student/dto We have deprecated the use of interfaces. Please propose the changes to the DTO itself |
Hi @coolbung, the DTO's needs to updated according to the new schema right? |
|
For working on one of the adapter projects, you'd need to create a new adapter like the default one here Unless you wish to add any new fields / attributes to the user schema you don't need to modify the user schema. |
|
Hi, @coolbung. I've updated as desired, kindly review the changes and let me know of changes if required. |
|
Hi @coolbung, can you kindly review the changes and provide me with the feedback if any? |
|
Awesome start, and thank you so much for this contribution @shikharvashistha ! I have put inline comments in the code, please review those. Also, please create postgres adapters for school, student, teacher & group entities as well. These entities are pre-requisites for attendance. |
|
Hey @shikharvashistha -- will be great if you can update the code so we can get this merged. We're all looking forward to your contribution to the project ! |
Right now engaged in some university work will update asap PS : @coolbung Updated |
|
Hey @shikharvashistha -- can you add the adapters for other entities : Student, School, Teacher & Group which is required for Attendance. |
Greetings of the day,
This pull adds student schema changes to shiksha platform. Kindly review the pull and let me know in case of any changes if required.
Best
@shikharvashistha
BUILD