Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

エラー画像をアバターデコレーションでは表示しないように #651

Conversation

Npepperlinux
Copy link
Contributor

@Npepperlinux Npepperlinux commented Nov 6, 2024

アバターデコレーションで出現したエラー画像の大きさを制限するようにしました。
ただし、Container(width: )による横幅の制限がContainer(height: )と違い意図したとおりに動作しなかったため、marginで左右に間隔を開けています。

→アバターデコレーションではエラー画像の表示を無効にしました
Fix #649

@Npepperlinux Npepperlinux force-pushed the fix/network_image_error_icon_size branch from 58223af to b43826c Compare November 6, 2024 12:30
@Npepperlinux Npepperlinux changed the title エラー画像のサイズをアバターデコレーションでは制限するように エラー画像をアバターデコレーションでは表示しないように Nov 6, 2024
@shiosyakeyakini-info shiosyakeyakini-info merged commit efffa8c into shiosyakeyakini-info:develop Nov 10, 2024
1 check passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.73%. Comparing base (2773561) to head (1f1e0ca).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
lib/view/common/misskey_notes/network_image.dart 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #651      +/-   ##
===========================================
- Coverage    27.74%   27.73%   -0.01%     
===========================================
  Files          312      312              
  Lines        16294    16296       +2     
===========================================
  Hits          4520     4520              
- Misses       11774    11776       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info
Copy link
Owner

dart format .を動かすか、エディタで自動でフォーマットする設定にしてもらえるとうれしいです…!(そこでこけてたので)

@Npepperlinux Npepperlinux deleted the fix/network_image_error_icon_size branch November 10, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

エラーになったアバターアイコンの占有領域がでかい
3 participants