Fix: emit shoukaku type. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not ignore pnpm lockfiles |
I just followed the fact that the package-lock.json is in the gitignore |
|
package-lock.json are not required if we use pnpm |
My point is that I don't even want to have to force you to use a specific package manager, just the one you want. |
|
Is the pr tested, seems like the issue persist till now |
It's quite strange, I tried it locally, because as I mentioned, in my case |
|
I'm going to try again, because it's quite strange |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the type en problem: #179
I manually added the type for some reason, it takes the type of the EventEmitter, but in my case the method does not appear, so it was added manually, in
Shoukaku.tsand also inPlayer.ts.