Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update tools from the plugin qualitiy guidelines #1682

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

aragon999
Copy link
Contributor

The FroshPluginUploader is deprecated: https://github.com/FriendsOfShopware/FroshPluginUploader?tab=readme-ov-file#this-tool-is-abandoned-and-will-only-receive-bug-fixes-please-move-to-httpsgithubcomfriendsofshopwareshopware-cli

For the sw-cli-tools I am not sure, what the status there is, but I changed the naming a bit, to be not to confusing.

@bojanrajh bojanrajh requested a review from Isengo1989 February 4, 2025 07:21
@Isengo1989
Copy link
Collaborator

@aragon999 thx for the PR 👍

Can you please also remove it in -> guidelines/testing/store/quality-guidelines-apps/index.md

and remove it from the .wordlist.txt

Copy link
Collaborator

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove also in app folder and .wordlist.txt

@aragon999 aragon999 force-pushed the patch-3 branch 2 times, most recently from f2f6a95 to f7f5a9b Compare February 5, 2025 10:51
@aragon999
Copy link
Contributor Author

@Isengo1989 I updated the PR accordingly.

@aragon999 aragon999 requested a review from Isengo1989 February 5, 2025 10:52
@Isengo1989
Copy link
Collaborator

@aragon999 thx for the extra mile 🥇

@Isengo1989 Isengo1989 merged commit def84f4 into shopware:main Feb 6, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants