Allowing preference based rotuing for dot indices

Signed-off-by: Shourya Dutta Biswas <[email protected]>
shourya035 · Jan 3, 2024 · fa3e1d4 · fa3e1d4
1 parent 71d7e4d
commit fa3e1d4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java b/server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
@@ -1558,6 +1558,14 @@ public static void validateRefreshIntervalSettings(Settings requestSettings, Clu
         }
     }
 
+    /*
+        Method to check if a non-data stream index name starts with a dot (.)
+        Used across various validators to ensure that dot indices are exempt from certain restrictions
+     */
+    public static boolean shouldIndexBeIgnored(String indexName) {
+        return indexName.charAt(0) == '.' && indexName.startsWith(DataStream.BACKING_INDEX_PREFIX) == false;
+    }
+
     /**
      * Validates {@code index.translog.durability} is not async if the {@code cluster.remote_store.index.restrict.async-durability} is set to true.
      *

diff --git a/server/src/main/java/org/opensearch/cluster/routing/OperationRouting.java b/server/src/main/java/org/opensearch/cluster/routing/OperationRouting.java
@@ -34,6 +34,7 @@
 
 import org.opensearch.cluster.ClusterState;
 import org.opensearch.cluster.metadata.IndexMetadata;
+import org.opensearch.cluster.metadata.MetadataCreateIndexService;
 import org.opensearch.cluster.metadata.WeightedRoutingMetadata;
 import org.opensearch.cluster.node.DiscoveryNodes;
 import org.opensearch.cluster.routing.allocation.decider.AwarenessAllocationDecider;
@@ -344,7 +345,15 @@ private ShardIterator preferenceActiveShardIterator(
                 }
             }
             preferenceType = Preference.parse(preference);
-            checkPreferenceBasedRoutingAllowed(preferenceType, weightedRoutingMetadata);
+            /*
+             Apply preference based routing only if:
+             - Index is a data stream index
+             OR
+             - Index name does not start with a dot (.)
+            */
+            if (MetadataCreateIndexService.shouldIndexBeIgnored(indexShard.shardId().getIndexName()) == false) {
+                checkPreferenceBasedRoutingAllowed(preferenceType, weightedRoutingMetadata);
+            }
             switch (preferenceType) {
                 case PREFER_NODES:
                     final Set<String> nodesIds = Arrays.stream(preference.substring(Preference.PREFER_NODES.type().length() + 1).split(","))