Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change todos to todo in route name #247

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

ckrenslehner
Copy link
Contributor

Instead of curl http://localhost:8000/todos/ it needs to be curl http://localhost:8000/todo/.
The same change applies to the POST request.

I just tried the example and after applying this change, the example worked as described

@oddgrd
Copy link
Contributor

oddgrd commented Jan 15, 2024

Thanks! I see there is a disparity between the example in these docs and the one in our examples repository. We can merge this, but we should update this to /todo: https://github.com/shuttle-hq/shuttle-docs/blob/main/examples/rocket-postgres.mdx#L71 first. Would you mind adding that change @Krensi?

Instead of curl http://localhost:8000/todos/<id> it needs to be curl http://localhost:8000/todo/<id>
@ckrenslehner
Copy link
Contributor Author

ckrenslehner commented Jan 15, 2024

I updated the other occurrences. :-)

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thank you!

@oddgrd oddgrd merged commit ada4ccf into shuttle-hq:main Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants