feat: add state reconciliation admin cmds #1965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added new admin CLI commands for managing deployed projects and reconciling project states with ECS.
- Added
DeployedProjectscommand inadmin/src/args.rsto fetch all deployed projects - Added
ReconcileStatecommand inadmin/src/args.rsto reconcile project state with ECS state - Potential code duplication between
get_all_deployed_projects()andget_projects()inclient.rsas they hit same endpoint with different return types
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+156
to
+159
| pub async fn reconcile_state(&self, project_id: &str) -> Result<serde_json::Value> { | ||
| let path = format!("/admin/projects/reconcile/{project_id}"); | ||
| self.inner.post_json(&path, Option::<()>::None).await | ||
| } |
There was a problem hiding this comment.
style: Consider using a more specific return type than serde_json::Value to ensure type safety at compile time
| @@ -121,6 +130,10 @@ pub async fn run(args: Args) { | |||
| .unwrap(); | |||
| println!("{res:?}"); | |||
| } | |||
| Command::ReconcileState { project_id } => { | |||
| let res = client.reconcile_state(&project_id).await.unwrap(); | |||
There was a problem hiding this comment.
logic: Using unwrap() here could cause panic if API call fails. Consider adding error context like other commands do with expect()
Comment on lines
+152
to
+154
| let path = format!("/admin/projects"); | ||
| self.inner.get_json(&path).await | ||
| } |
There was a problem hiding this comment.
style: format! is unnecessary here since no string interpolation is being done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add commands to admin CLI for new admin endpoints.
How has this been tested? (if applicable)
Tested in dev environment.