Add Suport for google_compute_node_template to TGC (GoogleCloudPlat…

…form#10602)
shuyama1 · May 13, 2024 · 5d4addb · 5d4addb
1 parent cdbface
commit 5d4addb
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 1 deletion.
diff --git a/mmv1/templates/tgc/resource_converters.go.erb b/mmv1/templates/tgc/resource_converters.go.erb
@@ -45,6 +45,7 @@ func ResourceConverters() map[string][]cai.ResourceConverter {
 		"google_compute_global_forwarding_rule":           {compute.ResourceConverterComputeGlobalForwardingRule()},
 		"google_compute_instance":                         {compute.ResourceConverterComputeInstance()},
 		"google_compute_network":                          {compute.ResourceConverterComputeNetwork()},
+		"google_compute_node_template": 				           {compute.ResourceConverterComputeNodeTemplate()},
 		"google_compute_resource_policy":				           {compute.ResourceConverterComputeResourcePolicy()},
 		"google_compute_route":                  		       {compute.ResourceConverterComputeRoute()},
 		"google_compute_security_policy":                  {resourceConverterComputeSecurityPolicy()},
@@ -80,7 +81,7 @@ func ResourceConverters() map[string][]cai.ResourceConverter {
 		"google_spanner_instance_iam_binding":             {spanner.ResourceConverterSpannerInstanceIamBinding()},
 		"google_spanner_instance_iam_member":              {spanner.ResourceConverterSpannerInstanceIamMember()},
 		"google_project_service":                          {resourceConverterServiceUsage()},
-		"google_secret_manager_secret_version": 		   {secretmanager.ResourceConverterSecretManagerSecretVersion()},
+		"google_secret_manager_secret_version": 		       {secretmanager.ResourceConverterSecretManagerSecretVersion()},
 		"google_pubsub_lite_reservation":                  {pubsublite.ResourceConverterPubsubLiteReservation()},
 		"google_pubsub_lite_subscription":                 {pubsublite.ResourceConverterPubsubLiteSubscription()},
 		"google_pubsub_lite_topic":                        {pubsublite.ResourceConverterPubsubLiteTopic()},

diff --git a/mmv1/third_party/tgc/tests/data/example_google_compute_node_template.json b/mmv1/third_party/tgc/tests/data/example_google_compute_node_template.json
@@ -0,0 +1,22 @@
+[
+    {
+        "name": "//compute.googleapis.com/projects/{{.Provider.project}}/regions/us-central1/nodeTemplates/soletenant-tmpl",
+        "asset_type": "compute.googleapis.com/NodeTemplate",
+        "ancestry_path": "{{.Ancestry}}/project/{{.Provider.project}}",
+        "resource": {
+            "version": "beta",
+            "discovery_document_uri": "https://www.googleapis.com/discovery/v1/apis/compute/beta/rest",
+            "discovery_name": "NodeTemplate",
+            "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}",
+            "data": {
+                "cpuOvercommitType": "NONE",
+                "name": "soletenant-tmpl",
+                "nodeType": "n1-node-96-624",
+                "region": "projects/{{.Provider.project}}/global/regions/us-central1"
+            }
+        },
+        "ancestors": [
+            "organizations/{{.OrgID}}"
+        ]
+    }
+]
diff --git a/mmv1/third_party/tgc/tests/data/example_google_compute_node_template.tf b/mmv1/third_party/tgc/tests/data/example_google_compute_node_template.tf
@@ -0,0 +1,18 @@
+terraform {
+  required_providers {
+    google = {
+      source = "hashicorp/google-beta"
+      version = "~> {{.Provider.version}}"
+    }
+  }
+}
+
+provider "google" {
+  {{if .Provider.credentials }}credentials = "{{.Provider.credentials}}"{{end}}
+}
+
+resource "google_compute_node_template" "template" {
+  name      = "soletenant-tmpl"
+  region    = "us-central1"
+  node_type = "n1-node-96-624"
+}