add test for non-fail command execution in run_cmd

In c125f1e a behavior change was introduced, leading to crashes in case a command does not exist. This test ensures that even non-existing commands are properly handled under fail=False. Signed-off-by: Felix Moessbauer <[email protected]> Signed-off-by: Jan Kiszka <[email protected]>
siemens · Dec 5, 2024 · e23df24 · e23df24
1 parent bbbc087
commit e23df24
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/tests/test_commands.py b/tests/test_commands.py
@@ -29,7 +29,7 @@
 import subprocess
 import pytest
 from kas import kas
-from kas.libkas import TaskExecError, KasUserError
+from kas.libkas import TaskExecError, KasUserError, run_cmd
 from kas.attestation import file_digest_slow
 
 
@@ -418,3 +418,11 @@ def test_ff_merges(monkeykas, tmpdir):
     with open('kas.yml', 'w') as f:
         yaml.dump(kas_input, f)
     kas.kas(['checkout', 'kas.yml'])
+
+
+def test_cmd_not_found(monkeykas, tmpdir):
+    cmd = ['/usr/bin/kas-not-exists']
+    ret, _ = run_cmd(cmd, tmpdir, os.environ, fail=False)
+    assert ret != 0
+    with pytest.raises(FileNotFoundError):
+        run_cmd(cmd, tmpdir, os.environ, fail=True)