fix(storage): auto-close storage on session timeout

Do not leave the shared storage device opened if the owning session has not interacted with us before the session timeout expired. Signed-off-by: Cedric Hombourger <[email protected]>
siemens · Dec 29, 2024 · c2ee066 · c2ee066
1 parent 0e70d39
commit c2ee066
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/mtda/constants.py b/mtda/constants.py
@@ -71,6 +71,7 @@ class STORAGE:
     LOCKED = "LOCKED"
     UNLOCKED = "UNLOCKED"
     OPENED = "OPENED"
+    CORRUPTED = "CORRUPTED"
     UNKNOWN = "???"
     RETRY_INTERVAL = 0.5
     TIMEOUT = 30

diff --git a/mtda/main.py b/mtda/main.py
@@ -1693,6 +1693,18 @@ def session_event(self, info):
             # There are active sessions: reset power expiry
             self._power_expiry = None
 
+        elif event == CONSTS.SESSION.INACTIVE:
+            # If a session had the shared storage device opened but has gone
+            # quiet, close it to let others grab it. Let's assume that its
+            # content is corrupted: send a storage event that UIs may use to
+            # display a warning
+            session = info[1]
+            if self._storage_opened is True and self._storage_owner == session:
+                self.mtda.debug(2, "closing storage for idle session "
+                                   f"{session}, storage may be corrupted!")
+                self._storage_event(CONSTS.STORAGE.CORRUPTED)
+                self.storage_close(None)
+
     def _session_check(self, session=None):
         self.mtda.debug(3, f"main._session_check({session})")