Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-ui: add icon to toggle storage between host and target #379

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

fmoessbauer
Copy link
Member

No description provided.

This patch adds a new icon to the web UI to switch the storage between
the target and the host. This is mostly useful to switch between booting
from a mtda managed storage and a local storage.

Signed-off-by: Felix Moessbauer <[email protected]>
When initially loading the web-ui, the current state of the target needs
to be transmitted as well. For that, we emit the power-event after
connecting the websocket.

Signed-off-by: Felix Moessbauer <[email protected]>
@github-actions github-actions bot requested a review from chombourger December 19, 2023 03:08
@fmoessbauer
Copy link
Member Author

fmoessbauer commented Dec 19, 2023

@chombourger : Feel free to change the icons if you think the current ones are misleading. Another thing to clarify is how to block the storage toggle option in the web UI in case the target is on. Shall we disable the button in this case, or just accept that the user can click it and nothing happens?

cc @bovi

@chombourger
Copy link
Collaborator

@chombourger : Feel free to change the icons if you think the current ones are misleading. Another thing to clarify is how to block the storage toggle option in the web UI in case the target is on. Shall we disable the button in this case, or just accept that the user can click it and nothing happens?

cc @bovi

probably a good idea for the backend to emit some storage-locked / storage-unlocked events but this can be done in a later PR in my opinion

@chombourger chombourger merged commit 9fb8ad2 into siemens:master Dec 19, 2023
6 checks passed
@fmoessbauer fmoessbauer deleted the fm/storage-icon branch December 19, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants