Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes #431

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Misc changes #431

merged 4 commits into from
Jan 6, 2025

Conversation

chombourger
Copy link
Collaborator

No description provided.

zerorpc was using methods future.utils to be compatible with both Python
2.x and 3.x but Debian trixie does not ship python3-future. Replace uses
of the future module with (hopefully) equivalent Python 3.x constructs.

Signed-off-by: Cedric Hombourger <[email protected]>
Copy link

@kergoth kergoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chombourger
Copy link
Collaborator Author

LGTM

thank you @kergoth

@chombourger chombourger merged commit 4b88e07 into siemens:master Jan 6, 2025
5 checks passed
SPDX-License-Identifier: MIT
Copyright (c) 2015 François-Xavier Bourlet ([email protected])

Index: zerorpc-0.6.3/zerorpc/context.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the package is currently broken on trixie? Do we already have an upstream bug report?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I will submit the PR but the project appears to be orphaned. I have asked my colleagues in Bangalore to switch to a more main stream RPC framework (gRPC?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: https://github.com/0rpc/zerorpc-python not touched for 4 years
I had filed a PR for a different issue/fix and it did not get the attention of the maintainers

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW what I liked in zerorpc when starting with it back in 2017 was that it would transparently expose Python objects over the network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants