Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol default configs #139

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

volovyks
Copy link
Contributor

Let's set the default number of concurrent protocols to a higher number. This should stress test our multithreading design and messaging layer.
At first, I wanted to separate the T and P parameters, but this made little sense while introducing the breaking change.

The number of signature protocols remains unconstrained. Limits for T and P protocols are separate (each node can introduce 512 T and 512 P protocols and as a result process 1024*12(number of nodes in the system) parallel protocols)
cc @auto-mausx

@ChaoticTempest ~12,000 Tokyo tasks seem reasonable since they are mostly IO-bound. We can adjust these numbers after we have more metrics. For now higher number will give us better data.

@volovyks
Copy link
Contributor Author

@auto-mausx This change will not change the setup on the current dev env, but it would be a default when starting new networks.

@volovyks
Copy link
Contributor Author

Limiting on the contract level is more challenging since we will receive requests from many chains. For now, I'm assuming we are getting everything from NEAR.

cc @esaminu @Pessina please, check if such a price function makes sense. I believe it is more transparent.

@volovyks
Copy link
Contributor Author

I had trouble making 600+ simultaneous sign requests in test_experimental_signature_deposit. The number of pending requests was always outdated (expected) and stopped growing after 97 (unexpected). Added a few load testing functions for visibility on dev and other networks.

@volovyks
Copy link
Contributor Author

@ChaoticTempest I've updated the limits, let's merge this. I believe we are hitting the contract limit now. And the system is proven to work fine with 16.

@volovyks volovyks mentioned this pull request Jan 29, 2025
@ChaoticTempest ChaoticTempest merged commit 2bfd625 into develop Jan 29, 2025
2 of 3 checks passed
@ChaoticTempest ChaoticTempest deleted the serhii/refactor-parameters branch January 29, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants