feat: make sign queue use less shared state #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/cleanup-testing-interface
…pc into phuong/chore/cleanup-testing-interface
…pc into phuong/chore/cleanup-testing-interface
…pc into phuong/chore/cleanup-testing-interface
…pc into phuong/chore/cleanup-testing-interface
…e/cleanup-testing-interface
…e/cleanup-testing-interface
…ig-net/sig-mpc into phuong/feat/protocol-as-task
…ig-net/sig-mpc into phuong/feat/protocol-as-task
…/protocol-as-task
…/protocol-as-task
volovyks
previously approved these changes
Jan 8, 2025
| pub fn new() -> Self { | ||
| Self::default() | ||
| pub fn channel() -> (mpsc::Sender<SignRequest>, mpsc::Receiver<SignRequest>) { | ||
| mpsc::channel(MAX_SIGN_REQUESTS) |
There was a problem hiding this comment.
What would the behavior be if we got more than 1024 requests? Will they be dropped or wait to be added?
There was a problem hiding this comment.
I believe they will be dropped
There was a problem hiding this comment.
yeah, they'll be dropped but we'll have a whole entire sweep about adding these configs to the contract when we have more demand for it
ppca
previously approved these changes
Jan 8, 2025
| pub fn new() -> Self { | ||
| Self::default() | ||
| pub fn channel() -> (mpsc::Sender<SignRequest>, mpsc::Receiver<SignRequest>) { | ||
| mpsc::channel(MAX_SIGN_REQUESTS) |
There was a problem hiding this comment.
I believe they will be dropped
ChaoticTempest
dismissed stale reviews from ppca and volovyks
The base branch was changed.
…/sign-queue-channel
ppca
previously approved these changes
Jan 8, 2025
ChaoticTempest
force-pushed
the
phuong/feat/sign-queue-channel
branch
from
e80f62e to
5a70c08
Compare
ppca
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the sign queue less contentious with indexer. This allows signature manager to progress without indexer taking up the write lock for too long.
This makes it so that sign queue only gets created in the
SignatureManager, where a channel(sign_tx, sign_rx)is create between the indexer and the protocol loop. Thesign_txis used by the indexer to send messages over the channel tosign_rxwhich is acquired by theSignatureManageron creation and organizing of message requests