Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec file for metadata. #276

Closed
wants to merge 1 commit into from

Conversation

Nepomuceno
Copy link
Contributor

@Nepomuceno Nepomuceno commented Apr 9, 2023

First step trying to improve the specs at #275

What it does

Add the basic Spec file fore metadata.
This is inspired in the file of https://github.com/sigmf/sigmf-python/blob/main/sigmf/schema-meta.json

Assumptions

these assumprions need to be verified

  • There is a minimum of one channel that it is specified in the files.
  • Sample retes are always positive
  • The only version current cupported by this schema it is 1.0.0
  • Frequencies can be negative

What it is missing

In his pr it is still missing the implementation of the extensions but space it is given to them.

I did not have many sample files to tesst the validation of the schema if someone could help me with that would be great.

Add the basic Spec file fore metadata.
This is inspired in the file of https://github.com/sigmf/sigmf-python/blob/main/sigmf/schema-meta.json
@Nepomuceno Nepomuceno changed the title Add spec file dor metadata. Add spec file for metadata. Apr 10, 2023
@777arc
Copy link
Member

777arc commented Apr 10, 2023

  1. There is a minimum of one channel that it is specified in the files, correct, an empty captures array would negate the need for the recording to exist imo
  2. Sample rates are always positive, correct
  3. Yep it's OK if the latest release (1.0.0) is the only one supported, although we should talk about what the process is when a new release is added, e.g. we should archive the older schemas in a nice way
  4. Frequencies can be negative <currently in discussion in sigmf matrix chat, will update>

@777arc
Copy link
Member

777arc commented Apr 10, 2023

Is it possible to make an example of having a separate schema file for an extension, e.g. it could be a 1 field extension but just showing how the $ref stuff will look, and then people who have extensions can use it as an example for making their schema file? Not sure how much work that would be.

@romanziske
Copy link
Contributor

The json schema is missing the core:geolocation field.

@777arc
Copy link
Member

777arc commented Sep 18, 2023

closing because this will be included in the #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants