-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snapshot Profiling Feature Flag and Scaffolding #2170
base: main
Are you sure you want to change the base?
Conversation
…g config logging output.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
return config.getBoolean(CONFIG_KEY_ENABLE_SNAPSHOT_PROFILER, false); | ||
} | ||
|
||
interface ActivationNotifier { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This interface is here to facilitate testing. Later iterations of this class will have other mechanisms that help with testing but I wanted to start with the bare minimum and build from there feature by feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class acts as a test only AutoConfiguredOpenTelemetrySdkBuilder
with JUnit 5 extension support. Later iterations of the snapshot profiler tests will include a more completely configured SDK and make extensive use of the JUnit 5 extension capabilities.
The core testing strategy being used is to test the snapshot profiler agent extension more as a black box. This means that many tests will interact with the OpenTelemetry SDK rather than the agent extension classes directly and observe the side effects expected from the agent extension.
Finally, once the snapshot profiler is closer to fully implemented, this class helps configure OpenTelemetry in a simulated distributed system so the snapshot profiling extension can be tested more "end-to-end"
Add the OpenTelemetry SDK customization scaffolding for the snapshot profiling feature. The feature itself will encompass several followup PRs as the code is slowly ported into this repository.