Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate addresses API #20

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Integrate addresses API #20

merged 2 commits into from
Jan 16, 2024

Conversation

iAmmar7
Copy link
Contributor

@iAmmar7 iAmmar7 commented Jan 15, 2024

Using the CF client, integrate the Addresses API with pagination.

ref: https://github.com/signalwire/cloud-product/issues/8864

@iAmmar7
Copy link
Contributor Author

iAmmar7 commented Jan 15, 2024

This PR is dependent on the prettier setup PR #19. We should merge that one first.

@iAmmar7 iAmmar7 requested review from ryanwi and ayeminag January 15, 2024 16:17
@ryanwi
Copy link
Collaborator

ryanwi commented Jan 15, 2024

nice. Can a couple updates be added, either here or in follow-up?

  • be able filter by type
  • make the channels callable by populating the address text box and execuating the connect button?

@iAmmar7
Copy link
Contributor Author

iAmmar7 commented Jan 16, 2024

  • be able filter by type

This would require API changes. Currently, I don't seem to have a way to pass any filter. Even the pagination needs a bit improvement.

  • make the channels callable by populating the address text box and execuating the connect button?

This could be done in a separate PR.

@ryanwi

@iAmmar7 iAmmar7 merged commit 3ca5713 into main Jan 16, 2024
3 checks passed
@ryanwi
Copy link
Collaborator

ryanwi commented Jan 16, 2024

The RESt API does allow filter by type (with the type param). the SDK method should support that. I mentioned it in the original ticket, but as a comment not in the description.

@iAmmar7
Copy link
Contributor Author

iAmmar7 commented Jan 17, 2024

The RESt API does allow filter by type (with the type param). the SDK method should support that. I mentioned it in the original ticket, but as a comment not in the description.

Yes, I read your comment, thanks! We will need to make some changes to the SDK function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants