Add steering id config #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jpsantosbh
commented
Jan 30, 2024
jpsantosbh
commented
- add steering id config to route request to an dev box
giavac
reviewed
Jan 30, 2024
views/index.ejs
Outdated
| @@ -50,6 +50,10 @@ | |||
| <div class="card"> | |||
| <div class="card-body"> | |||
| <h5>Connect</h5> | |||
| <div class="form-group"> | |||
| <label for="steeringId">Address</label> | |||
There was a problem hiding this comment.
Label to be corrected please with Steering ID or similar.
giavac
reviewed
Jan 30, 2024
public/full.js
Outdated
| @@ -376,13 +376,18 @@ window.connect = async () => { | |||
| connectStatus.innerHTML = 'Connecting...' | |||
|
|
|||
| // Set a node_id for steering | |||
| const steeringId = undefined | |||
| const steeringId = () { | |||
There was a problem hiding this comment.
missing => before the curly brackets?
…all-fabric-client-beta into joao/add_steering_id_config # Conflicts: # public/full.js
iAmmar7
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.