[mod_lua] Add Dbh:query_rows #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1671/index.html |
ar45
force-pushed
the
mod_lua_query_rows
branch
2 times, most recently
from
4052057 to
f94f305
Compare
andywolk
force-pushed
the
mod_lua_query_rows
branch
from
f94f305 to
08c395f
Compare
andywolk
force-pushed
the
mod_lua_query_rows
branch
from
08c395f to
21b8b52
Compare
andywolk
force-pushed
the
mod_lua_query_rows
branch
from
21b8b52 to
94fcefd
Compare
The added method, query_rows, allows the retrieval of rows from a database without the need for a callback function, it fetches the rows and returns 3 arguments as show below. ``` lua local success, rows, err = dbh:query_rows(sql) ``` This function performs better with large number of rows. Test results below 50k rows returned. dbh:query(sql, callback) - 0.335949 seconds dbh:query_rows(sql) - 0.253178 seconds
andywolk
force-pushed
the
mod_lua_query_rows
branch
from
94fcefd to
7d2befa
Compare
andywolk
approved these changes
Jan 15, 2025
briankwest
approved these changes
Jan 15, 2025
|
@ar45 Thank you. |
|
nice work @ar45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added method, query_rows, allows the retrieval of rows from a database without the need for a callback function, it fetches the rows and returns 3 arguments as show below.
This function performs better with large number of rows. Test results below 50k rows returned.
dbh:query(sql, callback) - 0.335949 seconds
dbh:query_rows(sql) - 0.253178 seconds