[mod_timerfd] Fixed - continue timer loop after receiving a SIGSTOP #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1751/scan-build-result.txt |
|
@seven1240 can you please review this? |
|
@andywolk can you review this one? Thank you! |
andywolk
requested changes
Jan 14, 2025
andywolk
changed the title
andywolk
requested changes
Jan 15, 2025
When taking a snapshot of a machine which pauses the process, mod_timerfd exits and freeswitch, causing all channels to wait indefinitely. Check `errno == EINTR` and continue the timer loop.
Removed trailing whitespace to improve code formatting.
switch.h to be first
andywolk
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When taking a snapshot of a machine which pauses the process, mod_timerfd runtime thread exits, causing all channels to wait indefinitely.
Check
errno == EINTRand continue the timer loop.