Upgrade Playwright to the latest version 1.49.1
#1154
Conversation
|
| @@ -13,7 +13,6 @@ | |||
| "vite": "^5.4.10" | |||
| }, | |||
| "devDependencies": { | |||
| "@playwright/test": "^1.35.1", | |||
| "playwrigth-ws-inspector": "^1.0.0" | |||
There was a problem hiding this comment.
I had to remove this dependency because the Playwright failed with the latest version. @jpsantosbh, could you please check if we need this package anymore? It seems this dependency itself is using the Playwright, which is incompatible with the latest version.
There was a problem hiding this comment.
It's used in one test
I'll update the Playwright version in that package and do a new release
There was a problem hiding this comment.
done, just update it to [email protected] it's using the same Playwrigth version.
There was a problem hiding this comment.
Which test is using it? I couldn't find the error in the CI related to this dependency.
Also, is it a private package? Redirecting to the GitHub page mentioned on NPM leads me to the 404 page. https://www.npmjs.com/package/playwrigth-ws-inspector
There was a problem hiding this comment.
just update it to [email protected] it's using the same Playwrigth version.
Done, but now the CI is red again with the same error. @jpsantosbh
There was a problem hiding this comment.
something is weird...
Playwrigth is just a dev dependency on playwrigth-ws-inspector
It should not clash...
There was a problem hiding this comment.
This is the test that uses it:
https://github.com/signalwire/signalwire-js/blob/main/internal/e2e-js/tests/callfabric/websocket_reconnect.spec.ts#L41
Ah, this whole test suite is skipped, and that's why the CI wasn't showing any error.
It's public
The GitHub home page for this package is giving me 404: https://github.com/signalwire/playwright-ws-inspector
There was a problem hiding this comment.
something is weird...
Playwrigth is just a dev dependency on playwrigth-ws-inspector
Can I remove it for now? Since the test suite is already skipped, it won't affect the CI.
I am also unsure about the reasoning behind that specific test and its usage. If we want to simulate the network down/up in the e2e test, we already do this in the Video SDK tests, we can use the same thing in the CF testing as well, if needed.
There was a problem hiding this comment.
Ah, this whole test suite is skipped, and that's why the CI wasn't showing any error.
Something is weird cause the dependence is on the Playwrite fixture that all tests use.
So even with that test skipped it should error.
I'm checking the test results it's not a version clash. It's a missing dependency.
Maybe the package-lock is pinning an M1 build.
There was a problem hiding this comment.
Something is weird cause the dependence is on the Playwrite fixture that all tests use.
So even with that test skipped it should error.
I removed the whole usage of this package, that's how I was able to make the CI green. Without affecting any tests since the only test that relies on this package is skipped.
Description
Upgrade to the latest version in e2e test for both JS and Realtime-API packages.
Type of change
Code snippets
In case of new feature or breaking changes, please include code snippets.