-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a custom reporter for Playwright #1165
base: main
Are you sure you want to change the base?
Conversation
|
I have made this change to make it easier for me to debug. However, you guys can also read the logs in this PR's CI and see if it is helpful for you guys to debug and understand the test failure. If yes, we can consider merging this change. @ryanwi @giavac Since we have a custom reporter now, I can also make any other improvements if required. One improvement (or change) I was considering making is to log each message with the test title. Currently, we see logs starting with Open to suggestions. |
Re-running the CI just to make sure it's not showing false positive results. |
I like this idea. Maybe each test could have both a |
I realized that the test title would still not be enough considering that a single test can create multiple pages, that's why we differentiate those pages with So, your suggestion is better to uniquely identify each log based on the page and test. We can implement this I will do that in this PR; I would have to add this small change in all the tests. |
Description
This PR includes:
Type of change
Code snippets
In case of new feature or breaking changes, please include code snippets.