Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF SDK: Make dial and reattach a sync function #1171

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented Feb 7, 2025

Description

Remove unnecessary promise from dial and reattach.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 6dacbb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@signalwire/js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iAmmar7 iAmmar7 requested a review from jpsantosbh February 7, 2025 13:35
Copy link
Collaborator

@jpsantosbh jpsantosbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but to avoid issues document this PR as breaking change.

@iAmmar7
Copy link
Collaborator Author

iAmmar7 commented Feb 7, 2025

LGTM, but to avoid issues document this PR as breaking change.

Where should I document this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants