Skip to content

Commit

Permalink
FIx android build failed after upgrading android studio to Ladybug
Browse files Browse the repository at this point in the history
  • Loading branch information
MinSeungHyun committed Oct 17, 2024
1 parent fbac4f7 commit 64f4065
Show file tree
Hide file tree
Showing 10 changed files with 33 additions and 21 deletions.
6 changes: 3 additions & 3 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ android {
compileSdkVersion 34

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = '1.8'
jvmTarget = 17
}

sourceSets {
Expand Down
3 changes: 1 addition & 2 deletions android/app/src/debug/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.seunghyun.silgam">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<!-- Flutter needs it to communicate with the running application
to allow setting breakpoints, to provide hot reload, etc.
-->
Expand Down
3 changes: 1 addition & 2 deletions android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.seunghyun.silgam">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<uses-permission android:name="android.permission.INTERNET" />

Expand Down
5 changes: 2 additions & 3 deletions android/app/src/profile/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.seunghyun.silgam">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<!-- Flutter needs it to communicate with the running application
to allow setting breakpoints, to provide hot reload, etc.
-->
<uses-permission android:name="android.permission.INTERNET"/>
<uses-permission android:name="android.permission.INTERNET" />
</manifest>
12 changes: 12 additions & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@ allprojects {
google()
mavenCentral()
}

subprojects {
afterEvaluate { project ->
if (project.hasProperty('android')) {
project.android {
if (namespace == null) {
namespace project.group
}
}
}
}
}
}

rootProject.buildDir = '../build'
Expand Down
1 change: 0 additions & 1 deletion android/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
android.bundle.enableUncompressedNativeLibs=false
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
4 changes: 2 additions & 2 deletions android/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ pluginManagement {

plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "7.2.2" apply false
id "com.android.application" version "8.2.2" apply false
// START: FlutterFire Configuration
id "com.google.gms.google-services" version "4.3.15" apply false
id "com.google.firebase.crashlytics" version "2.9.9" apply false
// END: FlutterFire Configuration
id "org.jetbrains.kotlin.android" version "1.7.20" apply false
id "org.jetbrains.kotlin.android" version "2.0.20" apply false
}

include ":app"
13 changes: 7 additions & 6 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -958,10 +958,11 @@ packages:
image_gallery_saver:
dependency: "direct main"
description:
name: image_gallery_saver
sha256: "0aba74216a4d9b0561510cb968015d56b701ba1bd94aace26aacdd8ae5761816"
url: "https://pub.dev"
source: hosted
path: "."
ref: knottx
resolved-ref: "05675bd4d70f3f4dfd702ae4f0075fa09025c436"
url: "https://github.com/knottx/image_gallery_saver.git"
source: git
version: "2.0.3"
image_picker:
dependency: "direct main"
Expand Down Expand Up @@ -1136,10 +1137,10 @@ packages:
description:
path: just_audio
ref: "fix/memory-leak"
resolved-ref: aaff56c51209bb03bd8b33e4779590be2c68eecc
resolved-ref: a9e373f4102ae9e3ee9a0aebbf6a77a7bd89f13d
url: "https://github.com/silgam/just_audio"
source: git
version: "0.9.20"
version: "0.9.41"
just_audio_platform_interface:
dependency: transitive
description:
Expand Down
5 changes: 4 additions & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ dependencies:
screenshot: ^3.0.0
path_provider: ^2.1.4
share_plus: ^10.0.0
image_gallery_saver: ^2.0.3
image_gallery_saver:
git:
url: https://github.com/knottx/image_gallery_saver.git
ref: knottx
carousel_slider: ^5.0.0
smooth_page_indicator: ^1.2.0+3
google_mobile_ads: ^5.1.0
Expand Down

0 comments on commit 64f4065

Please sign in to comment.