Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 7.0.2 -- reduce memory consumption of password expiry processing #394

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Release 7.0.2 -- reduce memory consumption of password expiry processing #394

merged 7 commits into from
Feb 12, 2025

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Feb 10, 2025 •
edited
Loading

IDP-1414 IdP Export Sheet

Fixed

  • Optimized the database query that retrieves users for sending password expiry messages. This task runs before the Google Sheets export (and the external groups sync). The logs show that the password expiry task is sometimes the last to run and it does not finish.

Changed

  • Changed the order of scheduled task execution. Moved password expiry processing to last in case the fix doesn't work.

PR Checklist

  • Put version number in PR title (e.g. Release x.y.z - Summary of changes)
  • Documentation (README, local.env.dist, api.raml, etc.)
  • Tests created or updated
  • Run make composershow
  • Run make psr2

@briskt briskt requested a review from a team as a code owner February 10, 2025 09:12
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team February 10, 2025 09:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt merged commit 42d8ebe into main Feb 12, 2025
3 checks passed
@briskt briskt deleted the feature/improved-msg-processing branch February 12, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt left review comments

@mtompset mtompset mtompset left review comments

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @forevermatt @mtompset