Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewEntries] Allow senses w/o gloss but w/ definition #3536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 24, 2025

Fixes #3469


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.57%. Comparing base (2c7f099) to head (ee7cd3e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3536   +/-   ##
=======================================
  Coverage   74.56%   74.57%           
=======================================
  Files         285      285           
  Lines       11033    11035    +2     
  Branches     1342     1343    +1     
=======================================
+ Hits         8227     8229    +2     
+ Misses       2423     2422    -1     
- Partials      383      384    +1     
Flag Coverage Δ
backend 83.84% <ø> (ø)
frontend 66.35% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ReviewEntries] Cannot save entries without gloss even with definition
1 participant