Don't write productId, authors, or reviewers to snapshot

Even better, just don't write the productId (or the other dynamically calculated fields) in the first place
sillsdev · Oct 28, 2024 · 7441cc0 · 7441cc0
1 parent 36ee7dd
commit 7441cc0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/source/SIL.AppBuilder.Portal/common/public/workflow.ts b/source/SIL.AppBuilder.Portal/common/public/workflow.ts
@@ -188,5 +188,5 @@ export type StateNode = {
 
 export type Snapshot = {
   value: string;
-  context: WorkflowContext;
+  context: Omit<WorkflowContext, 'productId' | 'hasAuthors' | 'hasReviewers'>;
 };
diff --git a/source/SIL.AppBuilder.Portal/common/workflow/index.ts b/source/SIL.AppBuilder.Portal/common/workflow/index.ts
@@ -226,13 +226,25 @@ export class Workflow {
         ProductId: this.productId,
         Snapshot: JSON.stringify({
           value: Workflow.stateName(this.currentState),
-          context: context
+          context: {
+            ...context,
+            // don't write these values
+            productId: undefined,
+            hasAuthors: undefined,
+            hasReviewers: undefined
+          }
         } as Snapshot)
       },
       update: {
         Snapshot: JSON.stringify({
           value: Workflow.stateName(this.currentState),
-          context: context
+          context: {
+            ...context,
+            // don't write these values
+            productId: undefined,
+            hasAuthors: undefined,
+            hasReviewers: undefined
+          }
         } as Snapshot)
       }
     });