Rename superFormData var to form

The original code was necessary because there was a reactive declaration using a variable from the props named form to conditionally redirect if the form was accepted. This was factored out in the Svelte 5 upgrade. This changes in this commit were originally part of that PR, but were split out to make the Svelte 5 PR as minimal as possible.
sillsdev · Feb 4, 2025 · 84e0841 · 84e0841
1 parent 90de719
commit 84e0841
Show file tree

Hide file tree

Showing 10 changed files with 58 additions and 124 deletions.
diff --git a/...pBuilder.Portal/src/routes/(authenticated)/admin/settings/organizations/edit/+page.svelte b/...pBuilder.Portal/src/routes/(authenticated)/admin/settings/organizations/edit/+page.svelte
@@ -12,11 +12,7 @@
   }
 
   let { data }: Props = $props();
-  const {
-    form: superFormData,
-    enhance,
-    allErrors
-  } = superForm(data.form, {
+  const { form, enhance, allErrors } = superForm(data.form, {
     dataType: 'json',
     onUpdated(event) {
       if (event.form.valid) {
@@ -25,23 +21,19 @@
     }
   });
 
-  let getStoreInfo = $derived((store: (typeof $superFormData)['stores'][0]) =>
-    data.options.stores.find((s) => s.Id === store.storeId));
+  let getStoreInfo = $derived((store: (typeof $form)['stores'][0]) =>
+    data.options.stores.find((s) => s.Id === store.storeId)
+  );
 </script>
 
 <!-- <SuperDebug data={superForm} /> -->
 <form class="m-4" method="post" action="?/edit" use:enhance>
-  <input type="hidden" name="id" value={$superFormData.id} />
+  <input type="hidden" name="id" value={$form.id} />
   <LabeledFormInput name="admin_settings_organizations_name">
-    <input
-      class="input w-full input-bordered"
-      type="text"
-      name="name"
-      bind:value={$superFormData.name}
-    />
+    <input class="input w-full input-bordered" type="text" name="name" bind:value={$form.name} />
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_organizations_owner">
-    <select class="select select-bordered" name="owner" bind:value={$superFormData.owner}>
+    <select class="select select-bordered" name="owner" bind:value={$form.owner}>
       {#each data.options.users as option}
         <option value={option.Id}>{option.Name}</option>
       {/each}
@@ -52,31 +44,31 @@
       name="websiteURL"
       class="input input-bordered w-full"
       type="text"
-      bind:value={$superFormData.websiteURL}
+      bind:value={$form.websiteURL}
     />
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_organizations_buildEngineURL">
     <input
       name="buildEngineURL"
       class="input input-bordered w-full"
       type="text"
-      bind:value={$superFormData.buildEngineURL}
+      bind:value={$form.buildEngineURL}
     />
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_organizations_accessToken">
     <input
       name="buildEngineAccessToken"
       class="input input-bordered w-full"
       type="text"
-      bind:value={$superFormData.buildEngineAccessToken}
+      bind:value={$form.buildEngineAccessToken}
     />
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_organizations_logoURL">
     <input
       name="logoURL"
       class="input input-bordered w-full"
       type="text"
-      bind:value={$superFormData.logoURL}
+      bind:value={$form.logoURL}
     />
   </LabeledFormInput>
   <div>
@@ -94,14 +86,14 @@
           name="publicByDefault"
           class="toggle toggle-accent"
           type="checkbox"
-          bind:checked={$superFormData.publicByDefault}
+          bind:checked={$form.publicByDefault}
         />
       </div>
     </label>
   </div>
 
   <MultiselectBox header={m.org_storeSelectTitle()}>
-    {#each $superFormData.stores as store}
+    {#each $form.stores as store}
       <MultiselectBoxElement
         bind:checked={store.enabled}
         title={getStoreInfo(store)?.Name ?? ''}

diff --git a/...er.Portal/src/routes/(authenticated)/admin/settings/product-definitions/edit/+page.svelte b/...er.Portal/src/routes/(authenticated)/admin/settings/product-definitions/edit/+page.svelte
@@ -10,11 +10,7 @@
   }
 
   let { data }: Props = $props();
-  const {
-    form: superFormData,
-    enhance,
-    allErrors
-  } = superForm(data.form, {
+  const { form, enhance, allErrors } = superForm(data.form, {
     onUpdated(event) {
       if (event.form.valid) {
         goto('/admin/settings/product-definitions');
@@ -28,28 +24,23 @@
 
 <!-- <SuperDebug data={superForm} /> -->
 <form class="m-4" method="post" action="?/edit" use:enhance>
-  <input type="hidden" name="id" value={$superFormData.id} />
+  <input type="hidden" name="id" value={$form.id} />
   <LabeledFormInput name="admin_settings_productDefinitions_name">
-    <input
-      class="input w-full input-bordered"
-      type="text"
-      name="name"
-      bind:value={$superFormData.name}
-    />
+    <input class="input w-full input-bordered" type="text" name="name" bind:value={$form.name} />
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_productDefinitions_type">
     <select
       class="select select-bordered"
       name="applicationType"
-      bind:value={$superFormData.applicationType}
+      bind:value={$form.applicationType}
     >
       {#each data.options.applicationTypes as type}
         <option value={type.Id}>{type.Name}</option>
       {/each}
     </select>
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_productDefinitions_workflow">
-    <select class="select select-bordered" name="workflow" bind:value={$superFormData.workflow}>
+    <select class="select select-bordered" name="workflow" bind:value={$form.workflow}>
       {#each workflows.filter((w) => w.Type) as workflow}
         <option value={workflow.Id}>{workflow.Name}</option>
       {/each}
@@ -59,7 +50,7 @@
     <select
       class="select select-bordered"
       name="rebuildWorkflow"
-      bind:value={$superFormData.rebuildWorkflow}
+      bind:value={$form.rebuildWorkflow}
     >
       <option value={null}>{m.admin_settings_productDefinitions_noWorkflow()}</option>
       {#each rebuildWorkflows.filter((w) => w.Type) as workflow}
@@ -71,7 +62,7 @@
     <select
       class="select select-bordered"
       name="republishWorkflow"
-      bind:value={$superFormData.republishWorkflow}
+      bind:value={$form.republishWorkflow}
     >
       <option value={null}>{m.admin_settings_productDefinitions_noWorkflow()}</option>
       {#each republishWorkflows.filter((w) => w.Type) as workflow}
@@ -83,14 +74,14 @@
     <textarea
       name="description"
       class="textarea textarea-bordered w-full"
-      bind:value={$superFormData.description}
+      bind:value={$form.description}
     ></textarea>
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_productDefinitions_properties">
     <textarea
       name="properties"
       class="textarea textarea-bordered w-full"
-      bind:value={$superFormData.properties}
+      bind:value={$form.properties}
     ></textarea>
   </LabeledFormInput>
   {#if $allErrors.length}

diff --git a/...AppBuilder.Portal/src/routes/(authenticated)/admin/settings/store-types/edit/+page.svelte b/...AppBuilder.Portal/src/routes/(authenticated)/admin/settings/store-types/edit/+page.svelte
@@ -9,11 +9,7 @@
   }
 
   let { data }: Props = $props();
-  const {
-    form: superFormData,
-    enhance,
-    allErrors
-  } = superForm(data.form, {
+  const { form, enhance, allErrors } = superForm(data.form, {
     onUpdated(event) {
       if (event.form.valid) {
         goto('/admin/settings/store-types');
@@ -24,20 +20,15 @@
 
 <!-- <SuperDebug data={superForm} /> -->
 <form class="m-4" method="post" action="?/edit" use:enhance>
-  <input type="hidden" name="id" value={$superFormData.id} />
+  <input type="hidden" name="id" value={$form.id} />
   <LabeledFormInput name="admin_settings_storeTypes_name">
-    <input
-      class="input w-full input-bordered"
-      type="text"
-      name="name"
-      bind:value={$superFormData.name}
-    />
+    <input class="input w-full input-bordered" type="text" name="name" bind:value={$form.name} />
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_storeTypes_description">
     <textarea
       name="description"
       class="textarea textarea-bordered w-full"
-      bind:value={$superFormData.description}
+      bind:value={$form.description}
     ></textarea>
   </LabeledFormInput>
   {#if $allErrors.length}

diff --git a/.../SIL.AppBuilder.Portal/src/routes/(authenticated)/admin/settings/stores/edit/+page.svelte b/.../SIL.AppBuilder.Portal/src/routes/(authenticated)/admin/settings/stores/edit/+page.svelte
@@ -9,11 +9,7 @@
   }
 
   let { data }: Props = $props();
-  const {
-    form: superFormData,
-    enhance,
-    allErrors
-  } = superForm(data.form, {
+  const { form, enhance, allErrors } = superForm(data.form, {
     onUpdated(event) {
       if (event.form.valid) {
         goto('/admin/settings/stores');
@@ -24,24 +20,19 @@
 
 <!-- <SuperDebug data={superForm} /> -->
 <form class="m-4" method="post" action="?/edit" use:enhance>
-  <input type="hidden" name="id" value={$superFormData.id} />
+  <input type="hidden" name="id" value={$form.id} />
   <LabeledFormInput name="stores_attributes_name">
-    <input
-      class="input w-full input-bordered"
-      type="text"
-      name="name"
-      bind:value={$superFormData.name}
-    />
+    <input class="input w-full input-bordered" type="text" name="name" bind:value={$form.name} />
   </LabeledFormInput>
   <LabeledFormInput name="stores_attributes_description">
     <textarea
       name="description"
       class="textarea textarea-bordered w-full"
-      bind:value={$superFormData.description}
+      bind:value={$form.description}
     ></textarea>
   </LabeledFormInput>
   <LabeledFormInput name="storeTypes_name">
-    <select class="select select-bordered" name="storeType" bind:value={$superFormData.storeType}>
+    <select class="select select-bordered" name="storeType" bind:value={$form.storeType}>
       {#each data.options as option}
         <option value={option.Id}>{option.Name}</option>
       {/each}

diff --git a/...r.Portal/src/routes/(authenticated)/admin/settings/workflow-definitions/edit/+page.svelte b/...r.Portal/src/routes/(authenticated)/admin/settings/workflow-definitions/edit/+page.svelte
@@ -12,11 +12,7 @@
   }
 
   let { data }: Props = $props();
-  const {
-    form: superFormData,
-    enhance,
-    allErrors
-  } = superForm(data.form, {
+  const { form, enhance, allErrors } = superForm(data.form, {
     dataType: 'json',
     onUpdated(event) {
       if (event.form.valid) {
@@ -43,28 +39,19 @@
 
 <!-- <SuperDebug data={superForm} /> -->
 <form class="m-4" method="post" action="?/edit" use:enhance>
-  <input type="hidden" name="id" value={$superFormData.id} />
+  <input type="hidden" name="id" value={$form.id} />
   <LabeledFormInput name="admin_settings_workflowDefinitions_name">
-    <input
-      class="input w-full input-bordered"
-      type="text"
-      name="name"
-      bind:value={$superFormData.name}
-    />
+    <input class="input w-full input-bordered" type="text" name="name" bind:value={$form.name} />
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_workflowDefinitions_storeType">
-    <select class="select select-bordered" name="storeType" bind:value={$superFormData.storeType}>
+    <select class="select select-bordered" name="storeType" bind:value={$form.storeType}>
       {#each data.storeTypes as storeType}
         <option value={storeType.Id}>{storeType.Name}</option>
       {/each}
     </select>
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_workflowDefinitions_productType">
-    <select
-      class="select select-bordered"
-      name="productType"
-      bind:value={$superFormData.productType}
-    >
+    <select class="select select-bordered" name="productType" bind:value={$form.productType}>
       <option value={ProductType.Android_GooglePlay}>Android GooglePlay</option>
       <option value={ProductType.Android_S3}>Android S3</option>
       <option value={ProductType.AssetPackage}>
@@ -76,11 +63,7 @@
     </select>
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_workflowDefinitions_workflowType">
-    <select
-      class="select select-bordered"
-      name="workflowType"
-      bind:value={$superFormData.workflowType}
-    >
+    <select class="select select-bordered" name="workflowType" bind:value={$form.workflowType}>
       <option value={1}>{m.admin_settings_workflowDefinitions_workflowTypes_1()}</option>
       <option value={2}>{m.admin_settings_workflowDefinitions_workflowTypes_2()}</option>
       <option value={3}>{m.admin_settings_workflowDefinitions_workflowTypes_3()}</option>
@@ -90,15 +73,11 @@
     <textarea
       name="description"
       class="textarea textarea-bordered w-full"
-      bind:value={$superFormData.description}
+      bind:value={$form.description}
     ></textarea>
   </LabeledFormInput>
   <LabeledFormInput name="admin_settings_workflowDefinitions_workflowScheme">
-    <select
-      class="select select-bordered"
-      name="workflowScheme"
-      bind:value={$superFormData.workflowScheme}
-    >
+    <select class="select select-bordered" name="workflowScheme" bind:value={$form.workflowScheme}>
       {#each data.schemes as scheme}
         <option value={scheme.Code}>{scheme.Code}</option>
       {/each}
@@ -108,7 +87,7 @@
     <select
       class="select select-bordered"
       name="workflowBusinessFlow"
-      bind:value={$superFormData.workflowBusinessFlow}
+      bind:value={$form.workflowBusinessFlow}
     >
       {#each businessFlows as flow}
         <option value={flow}>{flow}</option>
@@ -119,7 +98,7 @@
     <textarea
       name="properties"
       class="textarea textarea-bordered w-full"
-      bind:value={$superFormData.properties}
+      bind:value={$form.properties}
     ></textarea>
   </LabeledFormInput>
   <LabeledFormInput
@@ -136,7 +115,7 @@
         <input
           class="toggle toggle-warning border-warning"
           type="checkbox"
-          bind:group={$superFormData.options}
+          bind:group={$form.options}
           value={opt.value}
         />
       </div>
@@ -157,7 +136,7 @@
           name="enabled"
           class="toggle toggle-accent"
           type="checkbox"
-          bind:checked={$superFormData.enabled}
+          bind:checked={$form.enabled}
         />
       </div>
     </label>

diff --git a/...Builder.Portal/src/routes/(authenticated)/organizations/[id]/settings/groups/+page.svelte b/...Builder.Portal/src/routes/(authenticated)/organizations/[id]/settings/groups/+page.svelte
@@ -9,7 +9,6 @@
   }
 
   let { data }: Props = $props();
-  // export let form: ActionData;
   const { form: addForm, enhance: addEnhance, allErrors } = superForm(data.addForm);
   const { form: deleteForm, enhance: deleteEnhance } = superForm(data.deleteForm);
 </script>