.NET8 Windows for SIL.Windows.Forms #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibPalaso Tests 46 files + 1 46 suites +1 10m 49s ⏱️ +17s For more details on these failures, see this check. Results for commit 93206a7. ± Comparison against base commit 46fa5f0. This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Updated L10NSharp to 8, which is the version that adds support for .NET8 Windows. Removed some old app.config settings that were causing build warnings. Updated some of the old .NET menu items for the newer style MenuStrip/MenuItem style. Also removed the old CAS-style PermissionSet attributes. This has precedent in FLEx, I believe. Also removed ImageToolbox controls -- they appear to be unused within SIL, and the third-party dependency is Framework 4.6.1 only. The other ancient third-party dependency we have is Enchant, which does appear to be used. But I have marked those two direct references as Obsolete, so we should see build warnings for consumers.
….Windows.Forms like all the others, but it doesn't.
With .NET8, the LocalApplicationData property has a different value than with Framework, causing a test failure in this class. That test ended reading the temp file from a previous test. I refactored the file pathing and directory creation to be adapted from the SettingsProvider itself, which should make it more flexible.
josephmyers
force-pushed
the
net8windows/sil-windows-forms
branch
from
93206a7 to
ba9a4c5
Compare
Palaso Tests 4 files + 1 4 suites +1 16m 59s ⏱️ + 1m 26s Results for commit 3591b45. ± Comparison against base commit c06c991. This pull request removes 9 and adds 65 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…nstant string. This was necessary to be more explicit in the test what is actually being fixed, while avoiding .Codebase, which produces a warning in modern .NET.
Also marked its test class with the same. Also marked another test class Windows-only, though it doesn't have to be Windows-only (just how it was written). This attribute is only supported with .NET5 and later, so on Framework there will be no marking. These changes fix a large number of build warnings.
hahn-kev
approved these changes
Nov 14, 2024
|
@hahn-kev I'm seeing the Versions between the server and my local are similar, but: I don't think that would matter? |
This doesn't really gain us anything, and it clutters up the build/test log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated L10NSharp to 8, which is the version that adds support for .NET8 Windows.
Removed some old app.config settings that were causing build warnings.
Updated some of the old .NET menu items for the newer style MenuStrip/MenuItem style.
Also removed the old CAS-style PermissionSet attributes. This has precedent in FLEx, I believe.
Also removed ImageToolbox controls -- they appear to be unused within SIL, and the third-party dependency is Framework 4.6.1 only.
The other ancient third-party dependency we have is Enchant, which does appear to be used. But I have marked those two direct references as Obsolete, so we should see build warnings for consumers.
This change is