Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved unit tests for FFmpegRunner #1364

Merged
merged 27 commits into from
Dec 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1642a26
Improved unit tests for FFmpegRunner to not take over display, be dep…
tombogle Nov 8, 2024
dba4714
Merge branch 'master' into improve-tests
tombogle Nov 14, 2024
cf3c597
Added CI build step to install ffprobe and ffmpeg before running tests.
tombogle Nov 16, 2024
43cbcd6
add a line to debug ffmpeg path
hahn-kev Nov 18, 2024
6d7fb90
search the path for ffmpeg
hahn-kev Nov 18, 2024
c82cea2
Removed inaccurate comments
tombogle Nov 18, 2024
6baf806
Merge branch 'master' into improve-tests
tombogle Nov 19, 2024
4fabb1a
+semver:minor Added FFmpegRunner.FfmpegMinimumVersion static property
tombogle Nov 19, 2024
590ffc1
Merge branch 'master' into improve-tests
tombogle Nov 19, 2024
02b8bfb
Added not in CHANGELOG.md about enhanced FFmpegRunner functionality: …
tombogle Nov 19, 2024
4901250
Allow (the only non-ignored test in) AudioPlayerTests to run on CI build
tombogle Nov 19, 2024
568c08b
Attempt to enable tests that use audio devices on CI build
tombogle Nov 19, 2024
b7e5120
Upgraded irrKlang DLLs to version 1.6
tombogle Nov 19, 2024
77ea045
Added specific NUnit cataegories for RequiresAudioOutputDevice and Re…
tombogle Nov 21, 2024
c0e0ce0
Added FFmpeg to path in build.yml
tombogle Nov 21, 2024
99e9bc4
removed `add-path` step from build.yml since that command is disabled…
tombogle Nov 21, 2024
10d0165
+semver:major Made MediaInfo look for the FFprobe exe in the same loc…
tombogle Nov 22, 2024
a77c5d9
Added installation of ffmpeg to Appveyor build and excluded tests tha…
tombogle Nov 22, 2024
2e5e58c
Try installing ab-audio-cable to see if that simulates presence of au…
tombogle Nov 22, 2024
269b695
Merge branch 'master' into improve-tests
tombogle Dec 3, 2024
c1e1801
Since vb-audio-cable doesn't have a choco installer, try downloading …
tombogle Dec 3, 2024
9b9df3a
Removed silent switch from VB Cable installer so I see if it is maybe…
tombogle Dec 5, 2024
f36c07d
Run VB Cable installer with elevated privileges and verify installation
tombogle Dec 5, 2024
bd14972
Gave up on installing a virtual audio input driver on Github build ag…
tombogle Dec 6, 2024
7ec02ef
See if explicitly creating SLDR cache folder will enable test setup t…
tombogle Dec 6, 2024
9b61be8
Revert "See if explicitly creating SLDR cache folder will enable test…
tombogle Dec 9, 2024
a045012
Merge branch 'master' into improve-tests
tombogle Dec 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a line to debug ffmpeg path
hahn-kev authored Nov 18, 2024
commit 43cbcd6e8ad5e358464ceaf3ec306c41ee68a0ba
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -40,6 +40,7 @@ jobs:
id: setup-ffmpeg
with:
ffmpeg-version: release
- run: echo ffmpeg path ${{ steps.setup-ffmpeg.outputs.ffmpeg-path }}

# there are cases where this will fail and we want to know about it
# so we don't use continue-on-error, but we still want to publish the results