Net8windows keyboarding and writing systems #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmyers
changed the base branch from
master
to
net8windows/sil-windows-forms
Updated L10NSharp to 8, which is the version that adds support for .NET8 Windows. Removed some old app.config settings that were causing build warnings. Updated some of the old .NET menu items for the newer style MenuStrip/MenuItem style. Also removed the old CAS-style PermissionSet attributes. This has precedent in FLEx, I believe. Also removed ImageToolbox controls -- they appear to be unused within SIL, and the third-party dependency is Framework 4.6.1 only. The other ancient third-party dependency we have is Enchant, which does appear to be used. But I have marked those two direct references as Obsolete, so we should see build warnings for consumers.
….Windows.Forms like all the others, but it doesn't.
It builds, and the tests appear to be not catastrophic, but I'll wait for the build server to do the actual verification. For .Keyboarding, I completely removed the Linux\ folder on .NET8 Windows. Same for the test files directed at Linux.
josephmyers
force-pushed
the
net8windows/keyboarding-and-writing-systems
branch
from
44dea17 to
8fd83be
Compare
|
Note that there are two (by my count) lingering Framework dependencies in libpalaso, for the libraries that target .net8-windows. These appear to be pretty well ingrained and difficult to upgrade, though we do maintain both. They are Enchant.Net and ibusdotnet. Both of these are .NET wrapper libraries for assemblies we don't control. So, I think our major options are these: rewrite, replace, or ignore. |
hahn-kev
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is