Fix ScrVers.equals()

sillsdev · Jul 3, 2023 · b132bbe · b132bbe
1 parent 9d59230
commit b132bbe
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sillsdev/scripture",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "TypeScript partial port of `libpalaso/SIL.Scripture`",
   "main": "dist/index.cjs.js",
   "module": "dist/index.es.js",

diff --git a/src/scr-vers.ts b/src/scr-vers.ts
@@ -46,11 +46,8 @@ export class ScrVers {
     return this._type;
   }
 
-  clearExcludedVerses(): void {
-    // do nothing
-  }
-
-  clearVerseSegments(): void {
-    // do nothing
+  equals(scrVers: ScrVers): boolean {
+    if (!scrVers.type || !this.type) return false;
+    return scrVers.type === this.type;
   }
 }
diff --git a/src/verse-ref.ts b/src/verse-ref.ts
@@ -384,7 +384,9 @@ export class VerseRef {
       verseRef._chapterNum === this._chapterNum &&
       verseRef._verseNum === this._verseNum &&
       verseRef._verse === this._verse &&
-      verseRef.versification === this.versification
+      verseRef.versification != null &&
+      this.versification != null &&
+      verseRef.versification.equals(this.versification)
     );
   }