-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm packages #1799
Update npm packages #1799
Conversation
Unit Test Results362 tests 362 ✅ 12s ⏱️ Results for commit 680e878. ♻️ This comment has been updated with latest results. |
This is the result of running `npm up` across the board.
The suppressImplicitAnyIndexErrors config is deprecated in Typescript 5.0 and above, and will be removed in Typescript 5.5. For now, we can still use it by setting "ignoreDeprecations": "5.0", but we'll need to go through our JS code and switch to individual @ts-ignore lines at every occurrence of implicit "any" before we can update to TS 5.5.
797c098
to
680e878
Compare
Curiously, after 3 re-runs, the Firefox shard 2/6 playwright E2E tests consistently fail for two tests (they all pass in Chromium):
I'm in favor of merging this with a separate issue to look into the two failing tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is very welcome and an important security update for all our NPM packages. The playwright E2E tests all pass on chromium reliably but curiously 2 tests fail on Firefox. More investigation is needed but I don't want to hold up merging this. So I will create a separate issue for the 2 failing Firefox tests.
Fixes #1798
Description
Updated NPM packages by running
npm up
. This did not update all packages, because in some cases we've put fixed version numbers into package.json rather than versions like^1.2
which would pull any 1.x package. But this is a start.Also had to add one line to tsconfig.json, because our
suppressImplicitAnyIndexErrors
config is deprecated since Typescript 5.0 and will go away in Typescript 5.5. But this PR updates to Typescript 5.4.5, so we don't (yet) have to go through and add individual@ts-ignore
comments before each occurrence of implicit "any" types. That's coming soon, though.Screenshots
No behavioral changes.
Checklist
Testing
make
, make sure site still loads.