Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose merge file for production build #1822

Merged
merged 2 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/integrate-and-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,9 @@ jobs:
cache: 'pnpm'
-
run: pnpm install
-
name: Prep for production build of legacy app
# docker compose build doesn't allow passing a `--target` parameter, so we have to replace the target in docker-compose.yml
run: "sed -i 's/target: development/target: production/g' docker-compose.yml"
-
name: Build legacy app
run: docker compose build --build-arg ENVIRONMENT=production --build-arg BUILD_VERSION=${{ steps.image.outputs.TAG_APP }} app
run: docker compose -f docker-compose.yml -f docker-compose.production.yml build --build-arg BUILD_VERSION=${{ steps.image.outputs.TAG_APP }} app
-
name: Verify version stamping
run: |
Expand Down
27 changes: 27 additions & 0 deletions docker-compose.production.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
services:

app:
build:
target: production
args:
- ENVIRONMENT=production
environment:
- ENVIRONMENT=production

lfmerge:
build:
args:
- ENVIRONMENT=production
environment:
- ENVIRONMENT=production

e2e-app:
build:
args:
- ENVIRONMENT=production
environment:
- ENVIRONMENT=production

test-php:
environment:
- ENVIRONMENT=production
Loading