Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-3101 Highlight range of source segments #2957

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

marksvc
Copy link
Collaborator

@marksvc marksvc commented Jan 17, 2025

This change is Reviewable

@marksvc marksvc added the will require testing PR should not be merged until testers confirm testing is complete label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.06%. Comparing base (855c1cb) to head (6089c2d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2957   +/-   ##
=======================================
  Coverage   82.05%   82.06%           
=======================================
  Files         544      544           
  Lines       31623    31630    +7     
  Branches     5139     5146    +7     
=======================================
+ Hits        25949    25956    +7     
- Misses       4905     4917   +12     
+ Partials      769      757   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylebuss kylebuss self-assigned this Jan 17, 2025
Copy link
Collaborator

@kylebuss kylebuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @marksvc)

@kylebuss kylebuss added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jan 17, 2025
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Jan 23, 2025
@Nateowami Nateowami force-pushed the task/sf-3101-highlight-source-range branch from f095cb8 to 6089c2d Compare January 23, 2025 16:41
@Nateowami Nateowami enabled auto-merge (squash) January 23, 2025 16:41
@Nateowami Nateowami merged commit 1b89392 into master Jan 23, 2025
14 of 15 checks passed
@Nateowami Nateowami deleted the task/sf-3101-highlight-source-range branch January 23, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing complete Testing of PR is complete and should no longer hold up merging of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants