Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lint job in workflow file #2961

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Rename lint job in workflow file #2961

merged 1 commit into from
Jan 20, 2025

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Jan 18, 2025

When looking at a list of jobs for branch protection rules, this job in particular has a confusingly meaningless name:


This change is Reviewable

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.00%. Comparing base (44d8083) to head (c1a319e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2961      +/-   ##
==========================================
- Coverage   82.00%   82.00%   -0.01%     
==========================================
  Files         544      544              
  Lines       31645    31645              
  Branches     5124     5129       +5     
==========================================
- Hits        25952    25951       -1     
  Misses       4929     4929              
- Partials      764      765       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Does something need to be configured in the SF settings before this is merged? (or is the pending check not related to our GH config?)

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@pmachapman pmachapman self-assigned this Jan 19, 2025
@Nateowami Nateowami force-pushed the feature/rename-lint-job branch from 3532a60 to c1a319e Compare January 20, 2025 00:47
@Nateowami Nateowami enabled auto-merge (squash) January 20, 2025 00:48
@Nateowami Nateowami merged commit 0f5168c into master Jan 20, 2025
15 checks passed
@Nateowami Nateowami deleted the feature/rename-lint-job branch January 20, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants