SF-2860 Fix offline project add question error

[siltomato]

Fixes issue where adding a question with empty xforge indexeddb database would throw an error (see Jira for video capture).

---

This change is 

[siltomato]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/question-dialog/question-dialog.service.ts line 108 at r1 (raw file):

  private async canCreateAndEditQuestions(projectId: string): Promise<boolean> {
    const userId = this.userService.currentUserId;
    const project = (await this.projectService.getProfile(projectId)).data;

I'm not sure about this change. This seemed to work for retrieving a project profile doc, where get(projectId) to get a project doc would not when offline. Could this be because the project profile docs were loaded before I went offline on the project connect page?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (333c5d3) to head (7259515).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2966   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         544      544           
  Lines       31637    31637           
  Branches     5147     5142    -5     
=======================================
  Hits        25969    25969           
  Misses       4901     4901           
  Partials      767      767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Nateowami]

Please update the title to conform to the guidelines in CONTRIBUTING.md.

[Nateowami]

Thanks @siltomato

[pmachapman]

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @siltomato)

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/question-dialog/question-dialog.service.ts line 108 at r1 (raw file):

Previously, siltomato wrote…

I'm not sure about this change. This seemed to work for retrieving a project profile doc, where get(projectId) to get a project doc would not when offline. Could this be because the project profile docs were loaded before I went offline on the project connect page?

Yes, that will be it. Usually we load the project profile rather than the project, as you only really need the project doc if you want the paratextUsers property.