SF-3173 Show error when matching training pairs not selected #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaymondLuong3
added
the
will require testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2980 +/- ##
=======================================
Coverage 82.02% 82.03%
=======================================
Files 544 544
Lines 31691 31691
Branches 5130 5152 +22
=======================================
+ Hits 25995 25997 +2
+ Misses 4940 4938 -2
Partials 756 756 ☔ View full report in Codecov by Sentry. |
josephmyers
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Yep
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)
josephmyers
force-pushed
the
task/sf-3173-matching-books
branch
from
6e3e8aa to
0e1b8ed
Compare
josephmyers
added
ready to test
and removed
will require testing
RaymondLuong3
force-pushed
the
task/sf-3173-matching-books
branch
from
0e1b8ed to
759ee44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the books selected for training do not have selection in both the translated books and reference texts the user will be shown an error directing them to fix the mistake. This change forces the user to fix the mistake before generating the draft.
This change is