Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Various changes #1897

Draft
wants to merge 3 commits into
base: 3.0
Choose a base branch
from
Draft

API Various changes #1897

wants to merge 3 commits into from

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Feb 4, 2025 •
edited
Loading

Important

There are multiple commits - DO NOT SQUASH

  • The LeftAndMain_SearchFilter was only used by CMSMain with its CMSSiteTreeFilter in practice. There's no sense keeping this legacy API around.
  • Those gridfield state bits are always empty, so there's no need to check for them and the framework PR removes them entirely for search filters.
  • Everything needed in this repo for merging CMSMain's filtering and GridField's filtering. Includes some styling fixes to unify the two.

Issue

@GuySartorelli GuySartorelli marked this pull request as draft February 4, 2025 23:53
@GuySartorelli GuySartorelli mentioned this pull request Feb 4, 2025
Open
5 tasks
@GuySartorelli
API Remove unnecessary API
ea0a653 
The LeftAndMain_SearchFilter was only ever used by CMSMain with its
CMSSiteTreeFilter in practice. There's no sense keeping this legacy API
around.
@GuySartorelli
API Move const into FormSchema class in framework
38a4476
@GuySartorelli GuySartorelli force-pushed the pulls/3.0/searchfilter branch from 7a1ca6a to 38a4476 Compare February 5, 2025 04:08
@GuySartorelli GuySartorelli changed the title API Remove unnecessary API API Various changes Feb 5, 2025
@GuySartorelli GuySartorelli mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GuySartorelli