Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX re-label forgot password for uniq id #11568

Merged

Conversation

andrewandante
Copy link
Contributor

@andrewandante andrewandante commented Jan 20, 2025

Description

Defaults for non-Email unique identifier fields, including a TextField in the form and a sensible label.

Manual testing steps

Set unique_identifier_field to something non-email.
See that it changes the field label.

Issues

Fixes #11567

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@andrewandante andrewandante force-pushed the FIX_lost_password_for_non_email branch 2 times, most recently from e2853d9 to c5843c9 Compare January 20, 2025 20:57
@andrewandante andrewandante marked this pull request as ready for review January 20, 2025 22:56
@GuySartorelli GuySartorelli self-assigned this Jan 21, 2025
@andrewandante andrewandante force-pushed the FIX_lost_password_for_non_email branch from c5843c9 to 7e5eeb2 Compare January 22, 2025 04:11
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just noticed the branch this is targetting. No sense in this waiting until June - can you please retarget to 5.3 so it can be released as a patch?

Would be really good if you can include a unit test as well, if you have time.

@andrewandante andrewandante changed the base branch from 6 to 5.3 January 28, 2025 08:16
@andrewandante andrewandante force-pushed the FIX_lost_password_for_non_email branch from 7e5eeb2 to 194bcbe Compare January 28, 2025 08:19
@andrewandante andrewandante force-pushed the FIX_lost_password_for_non_email branch from 8798fa1 to 0e82c28 Compare January 28, 2025 09:05
@andrewandante
Copy link
Contributor Author

Alrighty @GuySartorelli I think I'm done messing about 😄

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this

@GuySartorelli GuySartorelli merged commit 690838b into silverstripe:5.3 Jan 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants