Merge pull request #108 from creative-commoners/pulls/0.4/php73

FIX Remove types for PHP 7.3 support
silverstripe · Jul 5, 2022 · ce4dec4 · ce4dec4
2 parents 3cd0d96 + dd6d3b7
commit ce4dec4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/code/elemental/ElementalBehatTestAdmin.php b/code/elemental/ElementalBehatTestAdmin.php
@@ -7,11 +7,11 @@
 
 class ElementalBehatTestAdmin extends ModelAdmin
 {
-    private static string $url_segment = 'elemental-behat-test-admin';
-    private static string $menu_title = 'Elemental Behat Test Admin';
-    private static string $menu_icon_class = 'font-icon-block-banner';
+    private static $url_segment = 'elemental-behat-test-admin';
+    private static $menu_title = 'Elemental Behat Test Admin';
+    private static $menu_icon_class = 'font-icon-block-banner';
 
-    private static array $managed_models = [
+    private static $managed_models = [
         ElementalBehatTestObject::class,
     ];
 }
diff --git a/code/elemental/ElementalBehatTestObject.php b/code/elemental/ElementalBehatTestObject.php
@@ -8,7 +8,7 @@
 
 class ElementalBehatTestObject extends DataObject
 {
-    private static string $table_name = 'ElementalBehatTestObject';
+    private static $table_name = 'ElementalBehatTestObject';
 
     public function CMSEditLink()
     {

diff --git a/composer.json b/composer.json
@@ -11,6 +11,7 @@
         }
     ],
     "require": {
+        "php": "^7.3",
         "silverstripe/framework": "^4",
         "silverstripe/cms": "^4",
         "guzzlehttp/guzzle": "^6.3 || ^7.3",