Merge pull request #11 from simdutf/AVX2_UTF8_validation_daniel

Some possible optimizations.
simdutf · Jan 30, 2024 · 713d29b · 713d29b
2 parents 66d51f5 + 7bc999b
commit 713d29b
Show file tree

Hide file tree

Showing 2 changed files with 279 additions and 145 deletions.
diff --git a/benchmark/Benchmark.cs b/benchmark/Benchmark.cs
@@ -95,7 +95,7 @@ protected void IntroduceError(byte[] utf8, Random random)
                             {
                                 utf8[position + 1] = (byte)((utf8[position + 1] & 0b11000011) | (s << 2));
                                 errorIntroduced = true;
-                                break; // Just introduce one surrogate error
+                                break; // Just introduce one surrogate error // TODO: having a loop that breaks immediately does not make much sense !!!!!!!!!!!!!!!!!!!!!!
                             }
                         }
                         break;
@@ -433,7 +433,7 @@ public class RealDataBenchmark : BenchmarkBase
                 @"data/turkish.utf8.txt",
                 @"data/german.utf8.txt",
                 @"data/japanese.utf8.txt")]
-        public string FileName;
+        public string? FileName;
 
         private string[] _lines = Array.Empty<string>();
         private byte[][] _linesUtf8 = Array.Empty<byte[]>();
@@ -607,7 +607,7 @@ public static void Main(string[] args)
             }
 
             // Create a BenchmarkDotNet config with a custom maximum parameter column width
-            var config = DefaultConfig.Instance.With(SummaryStyle.Default.WithMaxParameterColumnWidth(100));
+            var config = DefaultConfig.Instance.With(summaryStyle: SummaryStyle.Default.WithMaxParameterColumnWidth(100));
 
             // Check if a specific argument (e.g., "runall") is provided
             if (args.Length > 0 && args[0] == "runall")