Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrying on network error in Firefox and Safari #52

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Fix retrying on network error in Firefox and Safari #52

merged 3 commits into from
Jul 13, 2021

Conversation

Woyken
Copy link
Contributor

@Woyken Woyken commented Jul 12, 2021

Fixes #51

Added missing dot(".") at the end of Firefox error message.

@sindresorhus
Copy link
Owner

I wonder if this applies to Safari too as it uses a dot in this issue #41, but was also added without a dot.

// @peterj35

@Woyken
Copy link
Contributor Author

Woyken commented Jul 13, 2021

Unfortunately, I don't have safari to check myself.

This Gist has the error written in comment with a dot "TypeError: The Internet connection appears to be offline."

Also quick google search revealed few images where it looks like it probably does end with a dot
image
(Source)

I'll add it too

The Internet connection appears to be offline.
test.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Firefox network error contains "." at the end Fix retrying on network error in Firefox and Safari Jul 13, 2021
@sindresorhus sindresorhus merged commit 7828c0a into sindresorhus:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox doesn't retry on TypeError: NetworkError
2 participants