TDL-14890: Print user friendly error messages #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpatel41
requested review from
dbshah1212,
karanpanchal-crest and
savan-chovatiya
dbshah1212
approved these changes
Aug 30, 2021
dbshah1212
reviewed
Aug 30, 2021
tap_exacttarget/client.py
Outdated
| @@ -61,7 +61,7 @@ def get_auth_stub(config): | |||
| LOGGER.info('Failed to auth using V1 endpoint') | |||
| if not config.get('tenant_subdomain'): | |||
| LOGGER.warning('No tenant_subdomain found, will not attempt to auth with V2 endpoint') | |||
| raise e | |||
| raise Exception(str(e) + ". Please check your \'client_id\', \'client_secret\' or try adding the \'tenant_subdomain\'.") from None | |||
karanpanchal-crest
approved these changes
Sep 8, 2021
dbshah1212
reviewed
Sep 22, 2021
tap_exacttarget/client.py
Outdated
| @@ -61,7 +61,8 @@ def get_auth_stub(config): | |||
| LOGGER.info('Failed to auth using V1 endpoint') | |||
| if not config.get('tenant_subdomain'): | |||
| LOGGER.warning('No tenant_subdomain found, will not attempt to auth with V2 endpoint') | |||
| raise e | |||
| message = "{}. Please check your \'client_id\', \'client_secret\' or try adding the \'tenant_subdomain\'." | |||
dbshah1212
reviewed
Sep 22, 2021
tap_exacttarget/client.py
Outdated
| @@ -77,7 +78,8 @@ def get_auth_stub(config): | |||
| transport=transport) | |||
| except Exception as e: | |||
| LOGGER.info('Failed to auth using V2 endpoint') | |||
| raise e | |||
| message = "{}. Please check your \'client_id\', \'client_secret\' or \'tenant_subdomain\'." | |||
KrisPersonal
approved these changes
Oct 12, 2021
added 7 commits
October 13, 2021 09:54
Merged
KrisPersonal
approved these changes
Oct 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-14890: Print user-friendly error messages
Manual QA steps
Risks
Rollback steps