Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new files and changes #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Saunakghosh10
Copy link

Made some key changes made to refactor the LandingPage component:

  • Converted to JSX syntax from React.createElement for improved readability

  • Destructured styles object for cleaner code

  • Split into separate reusable Hero component for separation of concerns

  • Used semantic HTML tags like

    and
    for accessibility

  • Moved styles to external CSS modules instead of inline styles

  • Added className attributes and CSS classes for styling instead of inline styles

  • Imported logo image asset instead of hard coding

  • Added alt text to logo image for accessibility

  • Added PropTypes for type checking of props

  • Used hooks like useEffect if needed for data fetching etc

  • Improved accessibility with ARIA roles and labels

  • Implemented responsive design with CSS media queries

  • Refactored CSS using BEM methodology for reusable modular CSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant