Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CURRENT_TIMESTAMP breaking local table creation on mariadb #45

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

christoph-blessing
Copy link
Member

  • Run tests using mariadb instead of mysql
  • Test local table creation with CURRENT_TIMESTAMP
  • Fix CURRENT_TIMESTAMP breaking table creation

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3a89f03) 98.71% compared to head (93f707d) 98.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          23       23           
  Lines         780      780           
  Branches       95       95           
=======================================
  Hits          770      770           
  Misses          4        4           
  Partials        6        6           
Files Coverage Δ
link/infrastructure/config.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christoph-blessing christoph-blessing merged commit 84ac630 into sinzlab:main Oct 5, 2023
@christoph-blessing christoph-blessing deleted the fix_issue44 branch October 5, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on local table creation when source table uses CURRENT_TIMESTAMP
1 participant